Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk utilization percent metrics #382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Anton-Kalpakchiev
Copy link
Collaborator

@Anton-Kalpakchiev Anton-Kalpakchiev commented Nov 15, 2024

Currently, when we perform cache cleanup, we emit metrics on the size of the cache. However, it's useful to know the % of the cache being used, as well. More specifically, this metric is important when Kraken runs on hosts with different disk sizes. For example, the same metric of 50GB of disk being used can mean the cache is healthy (e.g. if its cache is 1TB), but it can also mean that the cache is unhealthy (the disk is 55GB and almost full).

There's a reason we need this metric implemented on Kraken's side, instead of the metric provided by whatever infra Kraken is running on. The agent usually runs on almost all hosts, but not all. These hosts' main purpose is to serve workloads and not to run the agent on them. The agent is just a tool to facilitate these workloads. Thus, the infra might not have been designed in a way, where it's easy to get metrics for specifically only those hosts that the agent runs on. Thus the metric must be emitted on Kraken's side.

  • Emit cache store percent utilization metrics, in addition to the already present absolute size metrics
  • Refactor the code and tests for readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant