Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose agent readiness endpoint on nginx port #387

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Anton-Kalpakchiev
Copy link
Collaborator

@Anton-Kalpakchiev Anton-Kalpakchiev commented Dec 10, 2024

Currently, all services except the agent and tracker have their health and readiness endpoints exposed on their nginx port. The agent's readiness endpoint is exposed by the agent server (a different server, not the nginx server!). To reach consistency across services, the agent's readiness endpoint should be exposed by its nginx server (on the nginx port).

To expose the readiness endpoint on the nginx server, we can reroute any requests to the nginx /readiness API to the agentserver, exactly like we already do for the /health endpoint.

Tested locally by building the devcluster: (16000 is the nginx port)

root@9234fcfc2af8:/etc/kraken# curl http://localhost:16000/readiness
OKroot@9234fcfc2af8:/etc/kraken# 

@Anton-Kalpakchiev Anton-Kalpakchiev requested review from gkeesh7, xinlongz1 and hweawer and removed request for xinlongz1 December 10, 2024 15:38
@Anton-Kalpakchiev Anton-Kalpakchiev merged commit fa42ec5 into master Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants