Fix to account for various different array types #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function can now properly handle np.ndarray, pd.series, pd.datetimeindex
edwinnglabs
approved these changes
Jul 10, 2024
edwinnglabs
deleted the
871-fit-method-fail-for-timezone-aware-timeseries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To allow is_ordered_datetime() to handle tz-aware vectors, use pandas.to_series().diff(), and ensure function to properly handle np.ndarray, pd.series, pd.datetimeindex.
Fixes #871
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
pytest local passed. Github action test passed workflow run