[Approach PR] [Not ready for review] - Adding support for mocks in test cleanup #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivacoder
commented
Oct 29, 2020
| @@ -881,6 +899,45 @@ private boolean isCheckedXPFlagName(ExpressionTree tree) { | |||
| public Description matchMethod(MethodTree tree, VisitorState state) { | |||
| if (disabled) return Description.NO_MATCH; | |||
|
|
|||
| if (!configTestMethodProperties.isEmpty() && tree != null && tree.getBody() != null && tree.getBody().getStatements() != null) { | |||
There was a problem hiding this comment.
@mkr-plse - This entire logic is very specific and I'm not happy with this approach.
But need your inputs to get this better and generic
sivacoder
commented
Oct 29, 2020
| @@ -41,5 +41,12 @@ | |||
| "linkURL": "<provide_your_url>", | |||
| "annotations": [ | |||
| "ToggleTesting" | |||
| ], | |||
| "testMethodProperties" : [ | |||
There was a problem hiding this comment.
This will act as the configuration for the test methods that needs to be cleanup. Structure is the same as methodProperties
There was a problem hiding this comment.
Just change the flagType for the method. So,
{
"methodName": "when",
"flagType": "mock",
"argumentIndex": 0
}
No separate testMethodProperties.
mkr-plse
reviewed
Oct 29, 2020
| List<? extends StatementTree> bt = tree.getBody().getStatements(); | ||
| for (StatementTree st : bt) { | ||
| if (st != null && st.getKind().equals(Kind.EXPRESSION_STATEMENT)) { | ||
| ExpressionStatementTree est = (ExpressionStatementTree) st; |
There was a problem hiding this comment.
- Shouldn't the statement count here be just one? Can we avoid the loop?
- How about calling
evalExpr(st)? If not,evalExpr(mit)below and use the result of that. - Before calling the
evalExpr, callgetXPAPIand see whether the API isMockmethod ? You may also want to updategetXPAPIto do the necessary processing to check forwhenand return the appropriate type.
So, the code will be:
API api = getXPAPI(mit) // may be st too.
if(api.equals(API.MOCK)) {
Value value = evalExpr(mit) // may be st too and update evalExpr
if(value != Value.BOT) {
// code starting at line 922.
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to discuss the possibilities of cleaning up mocks in tests. Approach seems very specific to few use-case and want to discuss approaches here with code.