Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --thriftNoRecurse flag to control passing -r to thrift #760

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

robbertvanginkel
Copy link

To allow generating thrift without generating for all dependencies. Flag
is a negative to preserve current behaviour.

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #760 into dev will increase coverage by 1.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #760      +/-   ##
==========================================
+ Coverage   88.44%   89.94%   +1.50%     
==========================================
  Files          42       42              
  Lines        4180     4636     +456     
==========================================
+ Hits         3697     4170     +473     
+ Misses        367      349      -18     
- Partials      116      117       +1     
Impacted Files Coverage Δ
root_peer_list.go 92.00% <0.00%> (-4.00%) ⬇️
idle_sweep.go 96.36% <0.00%> (-3.64%) ⬇️
inbound.go 80.62% <0.00%> (-1.58%) ⬇️
relay_messages.go 100.00% <0.00%> (ø)
preinit_connection.go 95.13% <0.00%> (+2.43%) ⬆️
outbound.go 90.05% <0.00%> (+2.92%) ⬆️
mex.go 77.72% <0.00%> (+3.31%) ⬆️
connection.go 92.58% <0.00%> (+3.42%) ⬆️
context_builder.go 91.08% <0.00%> (+3.45%) ⬆️
relay.go 87.12% <0.00%> (+3.79%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3edb77b...4ef1873. Read the comment docs.

thrift/thrift-gen/generate.go Outdated Show resolved Hide resolved
To allow generating thrift without generating for all dependencies. Flag
is a negative to preserve current behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants