pkp#10019 Fix publication update when modifying contributor

ubiquitypress · Jun 19, 2024 · 92d9cfd · 92d9cfd
1 parent dd3ac26
commit 92d9cfd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/controllers/grid/users/author/AuthorGridHandler.inc.php b/controllers/grid/users/author/AuthorGridHandler.inc.php
@@ -393,6 +393,8 @@ function deleteAuthor($args, $request) {
 		$authorDao->deleteById($authorId);
 		$json = DAO::getDataChangedEvent($authorId);
 		$json->setGlobalEvent('authorsUpdated');
+		$publication = $this->getPublication();
+		$publication = Services::get('publication')->edit($publication, [], Application::get()->getRequest());
 		return $json;
 	}
 

diff --git a/controllers/grid/users/author/form/PKPAuthorForm.inc.php b/controllers/grid/users/author/form/PKPAuthorForm.inc.php
@@ -256,9 +256,6 @@ function execute(...$functionParams) {
 				throw new Exception('Invalid primary contact ID. This author can not be a primary contact.');
 			}
 			$publication = Services::get('publication')->edit($publication, $params, Application::get()->getRequest());
-		} else {
-			// Log an event when publication data is updated
-			$publication = Services::get('publication')->edit($publication, [], Application::get()->getRequest());
 		}
 
 		return $authorId;