Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add Data Structures for Searching #1124

Open
wants to merge 57 commits into
base: develop
Choose a base branch
from
Open

Conversation

courtneycb
Copy link
Contributor

@courtneycb courtneycb commented Nov 27, 2018

WIP. This PR adds the Data Structures for Searching unit plan with 3 lessons for ages 11-14.

Resolves #773

TODO:

  • Discuss with Authors what text should be used for 'Key Quesitons' in lesson 1
  • Add 'standard text' under Computational Thinking connections header
  • Fix formatting of bullet points in the abstraction and evaluation sections on lesson 1
  • Resolve inconsistent capitalisation of 'computational thinking' and 'algorithmic thinking' throughout lessons.
  • Need to flesh out learning outcomes and computational thinking links for lesson 3. (Discuss with Authors).
  • Add tests for generated resources.

@courtneycb courtneycb added content: topics/lessons frontend Related to the website the user sees content: printables Related to the printable resources author Requires attention from a content author labels Nov 27, 2018
@courtneycb courtneycb added this to the 4.2.0 milestone Nov 27, 2018
@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #1124 into develop will decrease coverage by 3.57%.
The diff coverage is 23.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1124      +/-   ##
===========================================
- Coverage      100%   96.42%   -3.58%     
===========================================
  Files          118      123       +5     
  Lines         3687     3865     +178     
  Branches       414      442      +28     
===========================================
+ Hits          3687     3727      +40     
- Misses           0      136     +136     
- Partials         0        2       +2
Impacted Files Coverage Δ
.../generators/HashTableWorksheetResourceGenerator.py 16.85% <16.85%> (ø)
...es/generators/AlphabetToNumberResourceGenerator.py 21.05% <21.05%> (ø)
...urces/generators/RandomNumbersResourceGenerator.py 27.58% <27.58%> (ø)
csunplugged/topics/views.py 98.72% <33.33%> (-1.28%) ⬇️
.../HashTableTwentySlotsWorksheetResourceGenerator.py 45.45% <45.45%> (ø)
...ors/HashTableTenSlotsWorksheetResourceGenerator.py 50% <50%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873c683...0f97231. Read the comment docs.

@JackMorganNZ JackMorganNZ removed this from the 4.2.0 milestone Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author Requires attention from a content author content: printables Related to the printable resources content: topics/lessons frontend Related to the website the user sees
Development

Successfully merging this pull request may close these issues.

2 participants