Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build, unit tests, and linting #12

Merged
merged 13 commits into from
Apr 15, 2024
Merged

build, unit tests, and linting #12

merged 13 commits into from
Apr 15, 2024

Conversation

atar13
Copy link
Contributor

@atar13 atar13 commented Apr 11, 2024 •
edited
Loading

Added:

  • Build client/server on windows/linux
  • Run Unit tests for client/server/shared
  • Run linter (clang-tidy probably)

@atar13 atar13 changed the base branch from main to dev April 13, 2024 17:26
@atar13
ci: build: build client and server on Windows and Linux
6f549ab
@atar13
ci: tests: client/server/shared unit tests
22d9b01 
using google test for unit testing

Also changed client/server CMake to export a library with everything
except their respective main.cpp. This is used to access the
client/server code from the unit tests.
Tyler-Lentz
Tyler-Lentz approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@Tyler-Lentz Tyler-Lentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love testing!

EddieJ03
EddieJ03 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@EddieJ03 EddieJ03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the greatest testing setup of all time

@atar13 atar13 changed the title build client in GH actions build, unit tests, and linting Apr 15, 2024
@atar13 atar13 merged commit a798df8 into dev Apr 15, 2024
11 checks passed
@atar13 atar13 deleted the chore/ci branch April 15, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EddieJ03 EddieJ03 EddieJ03 approved these changes

@Tyler-Lentz Tyler-Lentz Tyler-Lentz approved these changes

@dmin12 dmin12 Awaiting requested review from dmin12

@gilkeidar gilkeidar Awaiting requested review from gilkeidar

@Cocodayow Cocodayow Awaiting requested review from Cocodayow

@tedpark217 tedpark217 Awaiting requested review from tedpark217

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atar13 @Tyler-Lentz @EddieJ03