DM Light Cut #201
Merged
DM Light Cut #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 5, 2024
Closed
Tyler-Lentz
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
super cool feature, and the extra dm speed with the control swap makes it feel very nice
one thing that might be nice for another PR would be to dynamically increase the DM speed as you ascend/descend so that you dont have to restart sprinting to increase your speed? also, i think it would feel more natural if ascending also increased your normal speed, maybe others agree?
oh and also I think you commented out the DM directional lighting while testing but then forgot to uncomment it back in, so I did that real quick so the DM view isn't super dark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: