Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Land DA container to Spack-Stack 1.6.0 #147

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

EdwardSnyder-NOAA
Copy link
Collaborator

@EdwardSnyder-NOAA EdwardSnyder-NOAA commented Oct 4, 2024

Description

This PR updates or adds files to support updating the Land DA container to spack-stack 1.6.0. Major changes include adding modulefile task files for singularity, added a singularity land_analysis file, and document changes.

The Land DA container was built with this PR using this landda dockerfile which inherits this spack-stack dockerfile. Testing was done with this container using the land_analysis test described in the docs which passed on GCP, AWS, and Hercules.

Anticipated changes to regression tests:

  • Is baseline change expected ?

Subcomponents involved:

  • apply_incr.fd (NOAA-PSL/land-apply_jedi_incr)
  • ufs_model.fd (ufs-community/ufs-weather-model)
  • none

Linked PR's and Issues:

Testing (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Hercules
  • CI
    • Completed
  • WE2E
    • Completed
  • PW-Clouds
    • AWS
    • AZURE
    • GCP

@EdwardSnyder-NOAA EdwardSnyder-NOAA marked this pull request as ready for review October 8, 2024 16:54
@jkbk2004
Copy link
Collaborator

@EdwardSnyder-NOAA
Copy link
Collaborator Author

Yes, @jkbk2004 I'll need to update that file. I got it to work but had to make a number of changes that I think could be resolved in a more elegant way. I'll try to get those changes in today.

Just a reminder this PR is for the previous ufs model hash. I'm still working on building the spack-stack with the proper modules to support the new ufs model hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants