Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Remove local copies of FindESMF from all components, update ESMF to 8.6.1 and MAPL to 2.46.3 #2406

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

[DRAFT] Remove local copies of FindESMF from all components, update ESMF to 8.6.1 and MAPL to 2.46.3 #2406

wants to merge 7 commits into from

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Aug 23, 2024 •
edited
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR requires two libraries (ESMF v8.6.1 and MAPL v 2.64.3) to be installed on all supported machines. So far, I'm testing these updates on Hercules using ue-esmf-8.6.1-mapl-2.46.2 spack-stack.

Commit Message:

* UFSWM - 
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - 
    * ccpp-physics - 
    * atmos_cubed_sphere - 
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * stochastic_physics -

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • AQM:
  • CDEPS:
  • CICE:
  • CMEPS:
  • CMakeModules:
  • FV3:
    • ccpp-physics:
    • atmos_cubed_sphere:
  • GOCART:
  • HYCOM:
  • MOM6:
  • NOAHMP:
  • WW3:
  • stochastic_physics:
  • None

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • New input data.
  • Updated input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DusanJovic-NOAA DusanJovic-NOAA marked this pull request as draft August 23, 2024 14:09
@bbakernoaa
Copy link
Collaborator

@DusanJovic-NOAA If you are testing this with the head of the develop branch from GOCART (hash bf5cf04) then you need to update the tests/parm/gocart/SU2G_instance_SU.rc file

Specifically this line

It will need to be changed with

volcano_srcfilen_explosive: /dev/null
volcano_srcfilen_degassing: /PATH_TO_NEW_FILE/so2_volcanic_emissions_CARN_v202401.degassing_only.rc

I have a copy of this new file on hera: /scratch1/RDARCH/rda-arl-gpu/Barry.Baker/emissions/GEFS/nexus/VOLCANIC/so2_volcanic_emissions_CARN_v202401.degassing_only.rc

Once you have this I think your problems with updating gocart will be solved

@DusanJovic-NOAA
Copy link
Collaborator Author

I made the suggested change in SU2G_instance_SU.rc and now I get this error:

$ grep 00000 err
pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
pe=00000 FAIL at line=01560    MAPL_EsmfRegridder.F90                   <destination masking with this regrid type is unsupported>
pe=00000 FAIL at line=01382    MAPL_EsmfRegridder.F90                   <status=1>
pe=00000 FAIL at line=00977    MAPL_AbstractRegridder.F90               <status=1>
pe=00000 FAIL at line=00097    NewRegridderManager.F90                  <status=1>
pe=00000 FAIL at line=01101    GriddedIO.F90                            <status=1>
pe=00000 FAIL at line=04539    ExtDataGridCompMod.F90                   <status=1>
pe=00000 FAIL at line=01468    ExtDataGridCompMod.F90                   <status=1>
pe=00000 FAIL at line=01838    MAPL_Generic.F90                         <status=1>
pe=00000 FAIL at line=01241    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=01204    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=01164    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=00832    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=00972    MAPL_CapGridComp.F90                     <status=1>

@bbakernoaa
Copy link
Collaborator

@DusanJovic-NOAA do you have the new MAPL/ESMF installed on hera?

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA do you have the new MAPL/ESMF installed on hera?

I don't. I already asked EPIC twice to install the updated version of MPAS.

@DusanJovic-NOAA
Copy link
Collaborator Author

@bbakernoaa I repeated the cpld_control_p8_intel test on Hercules with updated gocart (top of develop 327ff344) and MAPL 2.46.3 and it fails with the same error:

djovic@hercules-login-4: /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_4012304/cpld_control_p8_intel
$ grep 00000 err
  0: pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
  0: pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
  0: pe=00000 FAIL at line=01560    MAPL_EsmfRegridder.F90                   <destination masking with this regrid type is unsupported>
  0: pe=00000 FAIL at line=01382    MAPL_EsmfRegridder.F90                   <status=1>
  0: pe=00000 FAIL at line=00977    MAPL_AbstractRegridder.F90               <status=1>
  0: pe=00000 FAIL at line=00097    NewRegridderManager.F90                  <status=1>
  0: pe=00000 FAIL at line=01101    GriddedIO.F90                            <status=1>
  0: pe=00000 FAIL at line=04539    ExtDataGridCompMod.F90                   <status=1>
  0: pe=00000 FAIL at line=01468    ExtDataGridCompMod.F90                   <status=1>
  0: pe=00000 FAIL at line=01838    MAPL_Generic.F90                         <status=1>
  0: pe=00000 FAIL at line=01241    MAPL_CapGridComp.F90                     <status=1>
  0: pe=00000 FAIL at line=01204    MAPL_CapGridComp.F90                     <status=1>
  0: pe=00000 FAIL at line=01164    MAPL_CapGridComp.F90                     <status=1>
  0: pe=00000 FAIL at line=00832    MAPL_CapGridComp.F90                     <status=1>
  0: pe=00000 FAIL at line=00972    MAPL_CapGridComp.F90                     <status=1>

I also updated SU2G_instance_SU.rc to include these two lines:

# Volcanic pointwise sources
volcano_srcfilen_explosive: /dev/null
volcano_srcfilen_degassing: ./so2_volcanic_emissions_CARN_v202401.degassing_only.rc

My run directory on Hercules is /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_4012304/cpld_control_p8_intel

@junwang-noaa
Copy link
Collaborator

@weiyuan-jiang Can you access Hercules? May I ask if you can take a look as well?

@weiyuan-jiang
Copy link
Collaborator

@weiyuan-jiang Can you access Hercules? May I ask if you can take a look as well?

Yes, I will take a look

@bena-nasa
Copy link

bena-nasa commented Sep 25, 2024 •
edited
Loading

I made the suggested change in SU2G_instance_SU.rc and now I get this error:

$ grep 00000 err
pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
pe=00000 FAIL at line=01560    MAPL_EsmfRegridder.F90                   <destination masking with this regrid type is unsupported>
pe=00000 FAIL at line=01382    MAPL_EsmfRegridder.F90                   <status=1>
pe=00000 FAIL at line=00977    MAPL_AbstractRegridder.F90               <status=1>
pe=00000 FAIL at line=00097    NewRegridderManager.F90                  <status=1>
pe=00000 FAIL at line=01101    GriddedIO.F90                            <status=1>
pe=00000 FAIL at line=04539    ExtDataGridCompMod.F90                   <status=1>
pe=00000 FAIL at line=01468    ExtDataGridCompMod.F90                   <status=1>
pe=00000 FAIL at line=01838    MAPL_Generic.F90                         <status=1>
pe=00000 FAIL at line=01241    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=01204    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=01164    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=00832    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=00972    MAPL_CapGridComp.F90                     <status=1>

This crash is not related to the volcanic emissions files. So changing the volcanic emissions files cannot cause this. Either something else was changed or changing the volcanic emissions files just meant the model got further and you hit a different problem.
Could be because of the v2.46.3 update? But how you got to that block is mysterious, that is not the default Regridding option in anything so unless someone changed somehow how you got there is beyond me.

That said, the grid that is getting passed down to gocart and the cap to gocart, does that have a mask set on it somewhere else in UFS?

@junwang-noaa
Copy link
Collaborator

@DusanJovic-NOAA may I ask where your model source code is for the run /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_4012304/cpld_control_p8_intel?

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA may I ask where your model source code is for the run /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_4012304/cpld_control_p8_intel?

/work/noaa/fv3-cam/djovic/ufs/gocart_mapl/ufs-weather-model

@junwang-noaa
Copy link
Collaborator

From @bena-nasa: I have made branch:

https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4

with what should fix the issue you were seeing with MAPLv2.46.3, please try and let me know. If it fixes your issues we can make a v2.46.4 release of mapl and hotfix this onto our develop.

@RatkoVasic-NOAA would you please install this MAPL version on Hercules for us to test if it resolves the model failure? Thanks

@GeorgeVandenberghe-NOAA
Copy link
Collaborator

From @bena-nasa: I have made branch:

https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4

with what should fix the issue you were seeing with MAPLv2.46.3, please try and let me know. If it fixes your issues we can make a v2.46.4 release of mapl and hotfix this onto our develop.

@RatkoVasic-NOAA would you please install this MAPL version on Hercules for us to test if it resolves the model failure? Thank

What is the git syntax to get this new hotfix and build the new(er) MAPL? I am going to try to do this offline rather than waiting for possible down the road installation.

@junwang-noaa
Copy link
Collaborator

@RatkoVasic-NOAA @jkbk2004 @ulmononian May I ask if the EPIC library team can install the MAPL candidate_v2.46.4 in spack-stack 1.6.0?

We can't move on with the testing without the new library. Thanks

@GeorgeVandenberghe-NOAA
Copy link
Collaborator

GeorgeVandenberghe-NOAA commented Oct 1, 2024 via email

@RatkoVasic-NOAA
Copy link
Collaborator

@junwang-noaa @GeorgeVandenberghe-NOAA I can try to install that version. Which machine do you want to test?

@junwang-noaa
Copy link
Collaborator

@RatkoVasic-NOAA can you install it on Hercules? Thanks

@RatkoVasic-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA can you install it on Hercules? Thanks

@junwang-noaa will do.

@GeorgeVandenberghe-NOAA
Copy link
Collaborator

GeorgeVandenberghe-NOAA commented Oct 2, 2024 via email

@RatkoVasic-NOAA
Copy link
Collaborator

@GeorgeVandenberghe-NOAA I have never installed MAPL outside of spack-stack.

@bena-nasa can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags:

    version("2.48.0", sha256="60a0fc4fd82b1a05050666ae478da7d79d86305aff1643a57bc09cb5347323b7")
    version("2.47.2", sha256="d4ca384bf249b755454cd486a26bae76944a7cae3a706b9a7c9298825077cac0")
    version("2.47.1", sha256="ca3e94c0caa78a91591fe63603d1836196f5294d4baad7cf1d83b229b3a85916")
    version("2.47.0", sha256="66c862d2ab8bcd6969e9728091dbca54f1f420e97e41424c4ba93ef606088459")
    version("2.46.3", sha256="333e1382ab744302d28b6f39e7f5504c7919d77d2443d70af952f60cbd8f27e7")
    version("2.46.2", sha256="6d397ad73042355967de8ef5b521d6135c004f96e93ae7b215f9ee325e75c6f0")
    version("2.46.1", sha256="f3090281de6293b484259d58f852c45b98759de8291d36a4950e6d348ece6573")
    version("2.46.0", sha256="726d9588b724bd43e5085d1a2f8d806d548f185ed6b22a1b13c0ed06212d7be2")

@GeorgeVandenberghe-NOAA
Copy link
Collaborator

GeorgeVandenberghe-NOAA commented Oct 2, 2024 via email

@GeorgeVandenberghe-NOAA
Copy link
Collaborator

GeorgeVandenberghe-NOAA commented Oct 2, 2024 via email

@BrianCurtis-NOAA
Copy link
Collaborator

BrianCurtis-NOAA commented Oct 2, 2024 •
edited
Loading

I need the git syntax to properly get this hotfix https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4
…
On Wed, Oct 2, 2024 at 3:49 PM RatkoVasic-NOAA @.> wrote: @GeorgeVandenberghe-NOAA https://github.com/GeorgeVandenberghe-NOAA I have never installed MAPL outside of spack-stack. @bena-nasa https://github.com/bena-nasa can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags: version("2.48.0", sha256="60a0fc4fd82b1a05050666ae478da7d79d86305aff1643a57bc09cb5347323b7") version("2.47.2", sha256="d4ca384bf249b755454cd486a26bae76944a7cae3a706b9a7c9298825077cac0") version("2.47.1", sha256="ca3e94c0caa78a91591fe63603d1836196f5294d4baad7cf1d83b229b3a85916") version("2.47.0", sha256="66c862d2ab8bcd6969e9728091dbca54f1f420e97e41424c4ba93ef606088459") version("2.46.3", sha256="333e1382ab744302d28b6f39e7f5504c7919d77d2443d70af952f60cbd8f27e7") version("2.46.2", sha256="6d397ad73042355967de8ef5b521d6135c004f96e93ae7b215f9ee325e75c6f0") version("2.46.1", sha256="f3090281de6293b484259d58f852c45b98759de8291d36a4950e6d348ece6573") version("2.46.0", sha256="726d9588b724bd43e5085d1a2f8d806d548f185ed6b22a1b13c0ed06212d7be2") — Reply to this email directly, view it on GitHub <#2406 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY . You are receiving this because you were mentioned.Message ID: @.>
-- George W Vandenberghe Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 @.** 301-683-3769(work) 3017751547(cell)

I believe:

git remote add GEOS-ESM https://github.com/GEOS-ESM/MAPL
git remote update
git merge GEOS-ESM hotfix/bmauer/candidate_v2.46.4

(might be git merge GEOS-ESM/hotfix/bmauer/candidate_v2.46.4

@BrianCurtis-NOAA
Copy link
Collaborator

I typo'd, it's GEOS-ESM

@GeorgeVandenberghe-NOAA
Copy link
Collaborator

GeorgeVandenberghe-NOAA commented Oct 2, 2024 via email

@BrianCurtis-NOAA
Copy link
Collaborator

Dies not finding repository 46.3]$ cd MAPL @.*** MAPL]$ git remote add GOES-ESM https://github.com/GOES-ESM/MAPL @.*** MAPL]$ git remote update Fetching origin Fetching GOES-ESM Username for 'https://github.com': ... upon supplying this it fails to find the repository On Wed, Oct 2, 2024 at 4:59 PM Brian Curtis @.> wrote:
…
I need the git syntax to properly get this hotfix https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4 … <#m_-4507551138992535341_> On Wed, Oct 2, 2024 at 3:49 PM RatkoVasic-NOAA @.> wrote: @GeorgeVandenberghe-NOAA https://github.com/GeorgeVandenberghe-NOAA https://github.com/GeorgeVandenberghe-NOAA https://github.com/GeorgeVandenberghe-NOAA I have never installed MAPL outside of spack-stack. @bena-nasa https://github.com/bena-nasa https://github.com/bena-nasa https://github.com/bena-nasa can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags: version("2.48.0", sha256="60a0fc4fd82b1a05050666ae478da7d79d86305aff1643a57bc09cb5347323b7") version("2.47.2", sha256="d4ca384bf249b755454cd486a26bae76944a7cae3a706b9a7c9298825077cac0") version("2.47.1", sha256="ca3e94c0caa78a91591fe63603d1836196f5294d4baad7cf1d83b229b3a85916") version("2.47.0", sha256="66c862d2ab8bcd6969e9728091dbca54f1f420e97e41424c4ba93ef606088459") version("2.46.3", sha256="333e1382ab744302d28b6f39e7f5504c7919d77d2443d70af952f60cbd8f27e7") version("2.46.2", sha256="6d397ad73042355967de8ef5b521d6135c004f96e93ae7b215f9ee325e75c6f0") version("2.46.1", sha256="f3090281de6293b484259d58f852c45b98759de8291d36a4950e6d348ece6573") version("2.46.0", sha256="726d9588b724bd43e5085d1a2f8d806d548f185ed6b22a1b13c0ed06212d7be2") — Reply to this email directly, view it on GitHub <#2406 (comment) <#2406 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY . You are receiving this because you were mentioned.Message ID: @.> -- George W Vandenberghe Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 @.* 301-683-3769(work) 3017751547(cell) I believe: git remote add GOES-ESM https://github.com/GOES-ESM/MAPL git remote update git merge GOES-ESM hotfix/bmauer/candidate_v2.46.4 (might be git merge GOES-ESM/hotfix/bmauer/candidate_v2.46.4 — Reply to this email directly, view it on GitHub <#2406 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANDS4FVEG44S6NRDXZ6AZB3ZZQQ5PAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGE3DINZTHA . You are receiving this because you were mentioned.Message ID: @.*>
-- George W Vandenberghe Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 @. 301-683-3769(work) 3017751547(cell)

yes, apologies again, i mistyped the proper repo, change GOES-ESM to GEOS-ESM in all instructions

@RatkoVasic-NOAA
Copy link
Collaborator

Or start from the beginning:
git clone --recursive https://github.com/GEOS-ESM/MAPL.git -b hotfix/bmauer/candidate_v2.46.4

@GeorgeVandenberghe-NOAA
Copy link
Collaborator

GeorgeVandenberghe-NOAA commented Oct 2, 2024 via email

@DusanJovic-NOAA
Copy link
Collaborator Author

@lipan-NOAA I created this branch that you can use to test updates to gocart, mapsl and esmf. Compared to the current develop branch, it has:

  1. updated GOCART submodule (hash bf5cf04) as suggested in this comment
  2. updated modules to load new versions of ESMF and MAPL on Hercules
  3. updated gocart configuration files to use new volcano_srcfilen_degassing config file as described here

You can use this branch to run cpld_control_p8 test on Hercules.

@junwang-noaa
Copy link
Collaborator

@weiyuan-jiang @tclune would you please help?

@bena-nasa can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags:

@lipan-NOAA
Copy link
Collaborator

@DusanJovic-NOAA @junwang-noaa I'll test it and let you know. Thanks.

@tclune
Copy link

tclune commented Oct 7, 2024

@bena-nasa can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags:

Ben is unfortunately on vacation until Columbus day. I'm pinging @mathomp4 for assistance.

@mathomp4
Copy link

mathomp4 commented Oct 7, 2024

All. I'm testing now to make sure this doesn't affect GEOS (when merged into our current version of MAPL). If it works, I'll release v2.46.4 and GitFlow it up to main and develop. I'll also make a PR to spack mainline. @RatkoVasic-NOAA would you be able to make a PR into spack-stack wherever it is needed (not sure what version(s))?

@mathomp4 mathomp4 mentioned this pull request Oct 7, 2024
Merged
7 tasks
@RatkoVasic-NOAA
Copy link
Collaborator

@mathomp4 no need for PR, I can get whatever version is tagged and install new spack-stack environment using that version of MAPL.

@mathomp4
Copy link

mathomp4 commented Oct 7, 2024

@junwang-noaa @RatkoVasic-NOAA I have released MAPL 2.46.4:

https://github.com/GEOS-ESM/MAPL/releases/tag/v2.46.4

I'm waiting for our CI to be happy with the PR onto main and then I'll release MAPL 2.49.1 and make a PR to spack with the new versions.

@RatkoVasic-NOAA
Copy link
Collaborator

@mathomp4 great!
@junwang-noaa I'll create new environment on Hercules using that tag.

@RatkoVasic-NOAA
Copy link
Collaborator

RatkoVasic-NOAA commented Oct 7, 2024 •
edited
Loading

@junwang-noaa [email protected]/[email protected] is ready on Hercules:
/work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.4/install/modulefiles/Core

@mathomp4
Copy link

mathomp4 commented Oct 7, 2024

@junwang-noaa [email protected]/[email protected] is ready on Hercules: /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.4/install/modulefiles/Core

Fingers crossed it works!

@GeorgeVandenberghe-NOAA
Copy link
Collaborator

GeorgeVandenberghe-NOAA commented Oct 7, 2024 via email

@RatkoVasic-NOAA
Copy link
Collaborator

RatkoVasic-NOAA commented Oct 7, 2024 •
edited
Loading

Instructions on how to load this in the UFS build environment??
…

module use /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.4/install/modulefiles/Core
module load stack-intel/2021.9.0
module load stack-intel-oneapi-mpi/2021.9.0
module load cmake/3.23.1

@lipan-NOAA
Copy link
Collaborator

With MAPL-2.64.4, it runs and passes the previous error stage, but still gives the error.

Logfile: /work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/err
/work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/out

@GeorgeVandenberghe-NOAA
Copy link
Collaborator

GeorgeVandenberghe-NOAA commented Oct 8, 2024 via email

@mathomp4
Copy link

mathomp4 commented Oct 8, 2024

With MAPL-2.64.4, it runs and passes the previous error stage, but still gives the error.

Logfile: /work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/err /work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/out

I'll ping @weiyuan-jiang to see if he can see these files and get the error back to us.

@weiyuan-jiang
Copy link
Collaborator

I saw the error:
"FAIL at line=02767 Base_Base_implementation.F90 "

That means somewhere in the configure file, a non cubed-sphere grid is labeled as cubed-sphere grid. Otherwise, it will not go into that call. (https://github.com/GEOS-ESM/MAPL/blob/3295ceebe7e870aaca2018c12ea1ac82d0628fa5/base/Base/Base_Base_implementation.F90#L2630C4-L2633C1)

@RatkoVasic-NOAA
Copy link
Collaborator

module use /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.8.0/envs/test1/install/modulefiles/Core module load stack-intel/2021.9.0 module load stack-intel-oneapi-mpi/2021.9.0 module load cmake/3.23.1 When I do this I cannot see mapl/2.46.4 I get from module spider Versions: mapl/2.40.3-esmf-8.6.0 mapl/2.46.3-esmf-8.6.1

@GeorgeVandenberghe-NOAA use:

module use /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.4/install/modulefiles/Core
module load stack-intel/2021.9.0
module load stack-intel-oneapi-mpi/2021.9.0
module load cmake/3.23.1

module avail mapl

---------------------------------------- /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.4/install/modulefiles/intel-oneapi-mpi/2021.9.0/intel/2021.9.0 ----------------------------------------
   mapl/2.46.3-esmf-8.6.1    mapl/2.46.4-esmf-8.6.1 (D)

@weiyuan-jiang
Copy link
Collaborator

With MAPL-2.64.4, it runs and passes the previous error stage, but still gives the error.

Logfile: /work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/err /work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/out

Can you compare the configure files that have run successfully?

@lipan-NOAA
Copy link
Collaborator

@weiyuan-jiang Comparing with the successful case (/work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_2762037/cpld_bmark_p8_intel) using 2.40.3-esmf-8.6.0, I did not see any difference in the model configuration.

@ulmononian
Copy link
Collaborator

@DusanJovic-NOAA @junwang-noaa absolutely understand that testing is underway, though just wanted to touch base and see if there was any luck w/ mapl/2.46.4 & gocart? i saw @lipan-NOAA mentioned an error persisting w/ 2.46.4 in this comment, but wanted to check if there had been any progress. we are testing the ufs-wm w/ spack-stack/1.8.0 with intel classic compilers right now and want to provide the correct esmf/mapl pair for the ufs-wm. additionally, knowing which mapl/esmf version (and spack-stack version) the WM will move to may help to target development efforts for spack-stack w/ LLVM compilers.

@junwang-noaa
Copy link
Collaborator

@ulmononian No, the issue in MAPL 2.46.4 is not resolved yet.

@junwang-noaa
Copy link
Collaborator

@weiyuan-jiang Do you have any clue what might cause the failure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we update FindESMF.cmake and maybe the name of the imported esmf target