Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from integration with SRW's make_orog #603

Merged

Conversation

christinaholtNOAA
Copy link
Contributor

Synopsis

A set of changes to the drivers run as part of SRW's make_orog task.

  • Run commands seemed not to work as expected, so changed them to use config files.
  • More information was needed in the UW YAML in a couple of instances.

Also ordered the tests in each of the drivers.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

src/uwtools/tests/drivers/test_orog.py Outdated Show resolved Hide resolved
src/uwtools/tests/drivers/test_orog.py Show resolved Hide resolved
src/uwtools/tests/drivers/test_orog_gsl.py Show resolved Hide resolved
src/uwtools/tests/drivers/test_shave.py Show resolved Hide resolved
src/uwtools/tests/test_schemas.py Show resolved Hide resolved
docs/shared/filter_topo.yaml Show resolved Hide resolved
src/uwtools/drivers/orog_gsl.py Show resolved Hide resolved
src/uwtools/drivers/orog_gsl.py Outdated Show resolved Hide resolved
src/uwtools/drivers/orog_gsl.py Show resolved Hide resolved
src/uwtools/drivers/shave.py Show resolved Hide resolved
src/uwtools/tests/test_schemas.py Show resolved Hide resolved
src/uwtools/tests/test_schemas.py Outdated Show resolved Hide resolved
Copy link
Contributor

@maddenp-noaa maddenp-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever you decide to do w.r.t. the hardcoded orog filename(s) will be fine. On principle, and just repeating what I already argued, I think that values that are not configurable should not appear in configuration, but should be derived from actual configurable values. That might not be practically attainable immediately.

Fix the goof of applying parallel jsonschema to wrong driver.
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew, I think I got through everything - great fixes!

@christinaholtNOAA christinaholtNOAA merged commit b7ed02f into ufs-community:main Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants