fix: always unset editedFeature on editPanel close #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And only this panel. This was creating a weird bug, steps to reproduce: - create a marker - shift-click on the marker to edit the layer (so without explicitly closing the panel) - try to type the layer name: the panel would close This is also because currently the schema and render() are too dump, and when any `name` is changed then the `data` reflow is called, while it should not when editing the datalayer name. We want to: - have more targeted schema - have more specific reflow in render But that's for other PRs!
davidbgk
approved these changes
Oct 24, 2024
When finishing drawing a polygon/line, Leaflet.Editable will send both `editable:drawing:end` and `editable:drawing:commit`. In normal flow, we only need to listen to the later, and we only need to listen for the former in the case of pressing escape while drawing.
yohanboniface
force-pushed
the
panel-onclose
branch
from
1da0962
to
b36c03a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And only this panel.
This was creating a weird bug, steps to reproduce:
This is also because currently the schema and render() are too dump, and when any
nameis changed then thedatareflow is called, while it should not when editing the datalayer name.We want to:
But that's for other PRs!