Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14 QA added Block grid acceptance tests #16908

Merged
merged 30 commits into from
Aug 27, 2024
Merged

V14 QA added Block grid acceptance tests #16908

merged 30 commits into from
Aug 27, 2024

Conversation

andr317c
Copy link
Contributor

No description provided.

@andr317c andr317c marked this pull request as ready for review August 13, 2024 19:39
Copy link
Contributor

@nhudinh0309 nhudinh0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some comments

…A/block-grid

# Conflicts:
#	tests/Umbraco.Tests.AcceptanceTest/package-lock.json
#	tests/Umbraco.Tests.AcceptanceTest/package.json
…A/block-grid

# Conflicts:
#	tests/Umbraco.Tests.AcceptanceTest/package-lock.json
#	tests/Umbraco.Tests.AcceptanceTest/package.json
Copy link
Contributor

@nhudinh0309 nhudinh0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some comments

Copy link
Contributor

@nhudinh0309 nhudinh0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andr317c andr317c merged commit 3f8bae1 into v14/dev Aug 27, 2024
16 checks passed
@andr317c andr317c deleted the v14/QA/block-grid branch August 27, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants