Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal class being returned from media cache service #17213

Merged
merged 3 commits into from
Oct 9, 2024

Fix internal class being returned from media cache service

0b53515
Select commit
Loading
Failed to load commit list.
Merged

Fix internal class being returned from media cache service #17213

Fix internal class being returned from media cache service
0b53515
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) succeeded Oct 8, 2024 in 36s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (9.10 -> 9.10)

View detailed results in CodeScene

Details

Annotations

Check notice on line 66 in src/Umbraco.PublishedCache.HybridCache/Services/MediaCacheService.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

ℹ Getting worse: Constructor Over-Injection 

MediaCacheService increases from 8 to 9 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
View more details on CodeScene Delta Analysis