Support for SMTP OAuth authentication through easier IEmailSenderClient implementation #17484
+101
−29
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (contrib)
failed
Nov 19, 2024 in 22s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: +0.01 (9.13 -> 9.14)
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Large Method UmbracoBuilder.CoreServices.cs: AddCoreInitialServices
- Constructor Over-Injection EmailSender.cs: EmailSender
✅ Improving Code Health:
- Complex Method EmailSender.cs: SendAsyncInternal
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)
❌ Getting worse: Large Method
AddCoreInitialServices increases from 111 to 113 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 176 in src/Umbraco.Infrastructure/Mail/EmailSender.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)
✅ Getting better: Complex Method
SendAsyncInternal decreases in cyclomatic complexity from 16 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 71 in src/Umbraco.Infrastructure/Mail/EmailSender.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)
❌ New issue: Constructor Over-Injection
EmailSender has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Loading