Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run both cms and package migrations in upgrader #17575

Open
wants to merge 2 commits into
base: v13/dev
Choose a base branch
from
+100 −48

Use correct setting

99fd428
Select commit
Loading
Failed to load commit list.
Open

Run both cms and package migrations in upgrader #17575

Use correct setting
99fd428
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev) succeeded Nov 19, 2024 in 24s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.05 (9.22 -> 9.27)

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Constructor Over-Injection UnattendedUpgrader.cs: UnattendedUpgrader

✅ Improving Code Health:

  • Complex Method UnattendedUpgrader.cs: HandleAsync

Annotations

Check notice on line 92 in src/Umbraco.Infrastructure/Install/UnattendedUpgrader.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

✅ No longer an issue: Complex Method 

HandleAsync is no longer above the threshold for cyclomatic complexity

Check warning on line 46 in src/Umbraco.Infrastructure/Install/UnattendedUpgrader.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Constructor Over-Injection 

UnattendedUpgrader has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
View more details on CodeScene Delta Analysis