Feature: Document Workspace Info reload components #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored to use the new Document URL Repository. Plus other housekeeping on the main Document Workspace Info component.
to listen for the "Request Reload Structure" event
iOvergaard
approved these changes
Oct 29, 2024
|
Is the "half bugfix" that it fixes the update of the info-boxes? And the other half is that the bug regarding update of the property values is not fixed?
|
|
@mjpraxis Thanks for the follow-up. 🙏 My "half bugfix" comment was more that this PR also adds a feature, (the document URL repo code), not exclusively a bug fix, meaning it would be a bit cheeky of me to try to push it into the upcoming v15.0.0 release, so it'll be scheduled for v15.1.0. I believe the other half of the issue you raised (about the server-side updates), should be resolved by PR #2491 (which will be part of v15.0.0), I just forgot to link to your issue on that PR. 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes umbraco/Umbraco-CMS#17183.
Half feature, half bug fix. When saving/publishing a document, the components on the Info workspace view were not automatically updating. Using the Request Reload Structure event (from the workspace context), the Info components are refreshed on save/publish.
For the Links component, this makes use of a new dedicated Document URL Repository, (as opposed to observing the workspace context's
.urlsproperty).Types of changes
How to test?
Go to an existing document, go to the Info workspace view, rename the document (e.g. append a number), press Publish, notice that the URL is updated in the "Links" component and that the "History" component has the latest Save/Publish audit logs.