Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes custom block view for block list #2516

Conversation

warrenbuckley
Copy link
Contributor

Prep ready for hackathon work
Touched the two files to look at and left a comment to the issue for my own reminder tomorrow
umbraco/Umbraco-CMS#17316


Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Touched the two files to look at and left a comment to the issue for my own reminder tomorrow
@nielslyngsoe
Copy link
Member

This might already be solved here, so great help would be to confirm if this PR works:
#2515

And then it needs to be replicated to grid... :-)

@rickbutterfield
Copy link
Contributor

Yep I think my PR fixes this issue! From what I can see it has already been resolved for Block Grid, based on comments in the code

@warrenbuckley
Copy link
Contributor Author

Closing as Rick beat me to it
#2515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants