Make sure stream position is set to zero #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue in Umbraco Cloud where a file operation was working fine locally but not when pushed to Cloud. Looking into the logs Azure threw an exception:
System.ArgumentException: content.Position must be less than content.Length. Please set content.Position to the start of the data to upload.
The problem was obviously the position of the stream i was trying to write, but the same code was working just fine locally, so i guessed this was being handled by the PhysicalFileProvider and looking into it this turned out to be the case. So to stream line this behaviour it makes sense for the Azure Storage Provider to do the same (see: https://github.com/umbraco/Umbraco-CMS/blob/v14/dev/src/Umbraco.Core/IO/PhysicalFileSystem.cs#L182C1-L185C14)