Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust node versions to match minimum supported #107

Merged

Conversation

Shadouts
Copy link
Contributor

This change adjusts github workflows to match the minimum supported node version. package.json indicates that the minimum supported version of node is >= 16, but ci was building for 14 (incompatible) and release-please was building using 18.

If this change is unacceptable, I would recommend alternatively package.json engines entry be updated to >=18 and ci strategy node versions range ['18.x', '20.x']

@bucko13
Copy link
Contributor

bucko13 commented Dec 15, 2023

If this change is unacceptable, I would recommend alternatively package.json engines entry be updated to >=18 and ci strategy node versions range ['18.x', '20.x']

This feels preferable to me honestly especially given that Node 16 is past EoL. Was there a reason to try this first or was it just to err on the side of being conservative?

@Shadouts
Copy link
Contributor Author

If this change is unacceptable, I would recommend alternatively package.json engines entry be updated to >=18 and ci strategy node versions range ['18.x', '20.x']

This feels preferable to me honestly especially given that Node 16 is past EoL. Was there a reason to try this first or was it just to err on the side of being conservative?

Not upgrading maintains backward compatibility. If 16 gets dropped on this lib, then npm will yell when someone tries to install to their project using 16.

@bucko13 bucko13 merged commit e12241a into unchained-capital:master Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants