feat: Create a GitHub data source using the new Project structure #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I did not yet write any tests for this, and I'm sure codecov is going to complain about that. I will get to that, but I wanted to get this code up since it's large and exciting! |
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 56.22% 59.20% +2.98%
==========================================
Files 14 15 +1
Lines 635 733 +98
==========================================
+ Hits 357 434 +77
- Misses 272 289 +17
- Partials 6 10 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tarkatronic
added
Data Sources
JoseAngel1196
approved these changes
Aug 4, 2023
| ghOrgLogin := env.GithubOrg | ||
| slackToken := env.SlackAuthToken | ||
| /**** | ||
| * NOTE: This is working code at the moment, but will remain commented out |
| ) | ||
|
|
||
| func TestCollectFindingsSingleProjectSingleFinding(t *testing.T) { | ||
| server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
JoseAngel1196
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #75, and huge step toward enabling #43.
This converts the GitHub querying code to use the new
ProjectCollection/Project/Findingdata structures.I also included commented-out code in
internal/scan.gothat I used to prove this out. That is ultimately what will lead to the full enablement of #43.