Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make GH repos linkable and ignore internal repos #94

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

JoseAngel1196
Copy link
Contributor

@JoseAngel1196 JoseAngel1196 commented Feb 23, 2024

This Change

Make the GitHub repos linkable.
Ignore repos if they have been tagged as internal.

@JoseAngel1196 JoseAngel1196 changed the title Make GH repos linkable and ignore internal repos feat: Make GH repos linkable and ignore internal repos Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 56.75676% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 76.92%. Comparing base (2263c6c) to head (6af554d).

Files Patch % Lines
querying/github.go 55.55% 12 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   77.96%   76.92%   -1.05%     
==========================================
  Files          15       15              
  Lines         835      845      +10     
==========================================
- Hits          651      650       -1     
- Misses        173      182       +9     
- Partials       11       13       +2     
Flag Coverage Δ
unittests 76.92% <56.75%> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoseAngel1196 JoseAngel1196 marked this pull request as ready for review February 23, 2024 18:56
@JoseAngel1196 JoseAngel1196 requested a review from a team as a code owner February 23, 2024 18:56
Copy link

@SteveKekacs SteveKekacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoseAngel1196 JoseAngel1196 merged commit 1d93495 into main Feb 23, 2024
27 of 29 checks passed
@JoseAngel1196 JoseAngel1196 deleted the jose/make-gh-linkable branch February 23, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants