Remove extra log in line with rusheb discussion

[luciaquirke]

• summary currently included in serialize method
• split out W&B client and logger
  Next:
• add config files and dataset reference to the model artifact

[rusheb]

Suggested change

	logger.summary(
	logger.progress(

I reckon we should move it from the summary to a console log, because it clutters up the summary

Side-note, I'm kind of thinking the WandbLogger interface is a bit obscure. Maybe the progress function should be called something different?

[luciaquirke]

Ah yeah I didn't catch the meaning of progress. console?

[luciaquirke]

Hmm I need to think more about this

[luciaquirke]

Python is so weird. ChatGPT tells me that this logging configuration

        logging.basicConfig(
            stream=sys.stdout,
            level=logging.INFO,
            format="%(asctime)s %(levelname)s %(message)s",
            datefmt="%Y-%m-%d %H:%M:%S",
        )

affects the root logger, so it will affects all logs including those outside of this module. Should we put this in a setup module to make that clear? Then we could call logging.info directly rather than having the static progress method, which lets us decouple the console logger method from the W&B stuff.

[rusheb]

That makes sense, happy to do that. Thanks for looking into it!

[luciaquirke]

I've moved it to the utils module for now instead of its own setup class to avoid over-engineering, and renamed the WandbLogger to WandbClient so it can hold non-logging wandb stuff

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[rusheb]

@luciaquirke would you still like to try and merge this or should we close it?