Relax style validation #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After #247 the style regex became way too restrictive and doesn't allow shorthand values like: border: thin solid red; So I think we should just completely relax the style regex as it isn't really giving us any value.
Pull Request Test Coverage Report for Build 7017076306
💛 - Coveralls |
albertfdp
approved these changes
Nov 28, 2023
papandreou
approved these changes
Nov 28, 2023
|
Released as [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #247 the style regex became way too restrictive and doesn't allow shorthand values like:
border: thin solid red;
So I think we should just completely relax the style regex as it isn't really giving us any value.