Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ePD] 'Delete PD' not present in available_actions #3160

Open
wants to merge 6 commits into
base: epd
Choose a base branch
from

Conversation

roman-karpovich
Copy link
Collaborator

Delete only available if it was never sent to partner. 1. date_sent_to_partner is null. 2. Snapshot model does not include any changes to the date_sent_to_partner field.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #22985: 'Delete PD' not present in available_actions.

@@ -354,6 +355,13 @@ def _is_partnership_manager(self):
profile__country=self.context['request'].user.profile.country
).exists()

def _is_representative_office_manager(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

Copy link
Collaborator Author

@roman-karpovich roman-karpovich Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it comes from PartnershipManagerRepPermission (InterventionAmendmentDeleteView.permission_classes) . not sure if we really need this group here

# Conflicts:
#	src/etools/applications/partners/serializers/interventions_v3.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants