update djangolib #3308
Open
update djangolib #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domdinicola
force-pushed
the
djangolib
branch
2 times, most recently
from
c1df29f
to
bdb3f2f
Compare
domdinicola
force-pushed
the
djangolib
branch
2 times, most recently
from
e5cd02e
to
a008f81
Compare
domdinicola
force-pushed
the
update-reqs
branch
2 times, most recently
from
874fa3e
to
e26a309
Compare
|
@roman-karpovich can you please check the PR? tests are failing due unicef/unicef-djangolib#6 |
done |
ntrncic
reviewed
Aug 19, 2022
| @@ -117,6 +117,7 @@ def get_from_secrets_or_env(var_name, default=None): | |||
|
|
|||
| # DJANGO: HTTP | |||
| MIDDLEWARE = ( | |||
| 'unicef_djangolib.middleware.HealthCheckMiddleware', | |||
There was a problem hiding this comment.
why are we updating middleware, whats the point of this?
There was a problem hiding this comment.
https://github.com/unicef/unicef-djangolib/blob/develop/src/unicef_djangolib/middleware.py
it's the check that the server is up and the db is ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.