Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMSM - Restricting location type for Checkout #3691

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

emaciupe
Copy link
Contributor

[ch37442]

@emaciupe emaciupe changed the base branch from 37450/lmsm-sort-by-expiry-date-in-checkout to 37440/lmsm-make-location-mandatory-during-checkout June 17, 2024 15:55
…github.com:unicef/etools into 37442/lmsm-restricting-location-type-for-checkout

# Conflicts:
#	src/etools/applications/last_mile/tests/test_views.py
@emaciupe emaciupe added the READY label Jun 18, 2024
Base automatically changed from 37440/lmsm-make-location-mandatory-during-checkout to develop June 18, 2024 18:53
@@ -368,6 +369,19 @@ class Meta(TransferBaseSerializer.Meta):
'transfer_type', 'items', 'origin_check_out_at', 'destination_point'
)

def validate_destination_point(self, value):
transfer_type = self.initial_data['transfer_type']
destination_point = get_object_or_404(models.PointOfInterest, pk=value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's leave it for next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants