chg ! admin panel - process deduplication set - is supersuser #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #103 +/- ##
===========================================
- Coverage 95.18% 94.50% -0.69%
===========================================
Files 73 73
Lines 1538 1547 +9
Branches 168 169 +1
===========================================
- Hits 1464 1462 -2
- Misses 51 62 +11
Partials 23 23 ☔ View full report in Codecov by Sentry. |
domdinicola
reviewed
Oct 22, 2024
| @button( | ||
| label="Process", | ||
| permission=lambda request, obj, **kw: request.user.is_superuser, | ||
| ) |
There was a problem hiding this comment.
@vitali-yanushchyk-valor pls check how is_root is defined in hope
vitali-yanushchyk-valor
force-pushed
the
hotfix/process_superuser
branch
2 times, most recently
from
ccea19f
to
fd743ac
Compare
domdinicola
reviewed
Oct 30, 2024
| @@ -1,4 +1,4 @@ | |||
| from hope_dedup_engine.config import env | |||
|
|
|||
| ROOT_TOKEN = env("ROOT_TOKEN") | |||
| ROOT_TOKEN_HEADER = env("ROOT_TOKEN_HEADER", default="x-root-token") | |||
| ROOT_TOKEN = env("ROOT_ACCESS_TOKEN") | |||
There was a problem hiding this comment.
@vitali-yanushchyk-valor why are we changing env name?
domdinicola
reviewed
Oct 30, 2024
| @@ -45,11 +46,12 @@ class DeduplicationSetAdmin(AdminFiltersMixin, ExtraButtonsMixin, ModelAdmin): | |||
| def has_add_permission(self, request): | |||
| return False | |||
|
|
|||
| @button(label="Process") | |||
| @button(permission=is_root) | |||
There was a problem hiding this comment.
@vitali-yanushchyk-valor let's do have a function
if the status is failed you can rerun if superuser
if you are root you can run in any status
vitali-yanushchyk-valor
force-pushed
the
hotfix/process_superuser
branch
from
fd743ac
to
ace6668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.