Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to run CI from fork #4034

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft

Conversation

wozniakpl
Copy link
Contributor

@wozniakpl wozniakpl commented Jul 11, 2024

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.09%. Comparing base (6be036f) to head (d9292d4).
Report is 683 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4034      +/-   ##
===========================================
- Coverage    81.04%   79.09%   -1.95%     
===========================================
  Files          399      399              
  Lines        32564    32564              
  Branches      5350     5350              
===========================================
- Hits         26390    25758     -632     
- Misses        5249     5878     +629     
- Partials       925      928       +3     
Flag Coverage Δ
e2e ?
unittests 79.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@domdinicola
Copy link
Collaborator

@wozniakpl are we working on this?

@wozniakpl
Copy link
Contributor Author

@wozniakpl are we working on this?

It was agreed to not follow with that until we rework how we deal with CI/CD. Right now we have this deploy job that triggers Azure pipelines which are meant to be hidden from this repo in future.

When running from fork, it will never work because we can't share the Azure token that connects us to the pipelines.

A proper way IMO would be to completely remove the deployment-related stuff and manage deployment via some GitOps agent on our end. Then it should be simpler to manage running CI from forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants