Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.2 support #1023

Merged
merged 12 commits into from
May 1, 2024
Merged

PHP 7.2 support #1023

merged 12 commits into from
May 1, 2024

Commits on Apr 23, 2024

  1. update phpunit for php 7.2

    @cfc7-unikent
    cfc7-unikent committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    fbf381e View commit details
    Browse the repository at this point in the history

  2. can't use sizeof on non-countable

    @cfc7-unikent
    cfc7-unikent committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    52acd60 View commit details
    Browse the repository at this point in the history

  3. cannot use count to get strlen

    @cfc7-unikent
    cfc7-unikent committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f069e13 View commit details
    Browse the repository at this point in the history

  4. test data as arrays, cannot use old method on 7.2

    @cfc7-unikent
    cfc7-unikent committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f0754ae View commit details
    Browse the repository at this point in the history

  5. fix tests which never worked because of a fault assumption on the res… 

    …ults of count
    @cfc7-unikent
    cfc7-unikent committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e0c0286 View commit details
    Browse the repository at this point in the history

  6. fix test

    @cfc7-unikent
    cfc7-unikent committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    55898b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. use 7.2 in CI

    @cfc7-unikent
    cfc7-unikent committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a087b3a View commit details
    Browse the repository at this point in the history

  2. bump phpunit

    @cfc7-unikent
    cfc7-unikent committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    e8b523d View commit details
    Browse the repository at this point in the history

  3. bump phpunit

    @cfc7-unikent
    cfc7-unikent committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    769424f View commit details
    Browse the repository at this point in the history

  4. removed travis we do not use it

    @cfc7-unikent
    cfc7-unikent committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f71ffd6 View commit details
    Browse the repository at this point in the history

  5. fix docblock to note what is actually returned from this method

    @cfc7-unikent
    cfc7-unikent committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    cb7ac87 View commit details
    Browse the repository at this point in the history

  6. update messages to reflect different values returned from fee generat… 

    …ion - previous code contained wrongness
    @cfc7-unikent
    cfc7-unikent committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f058fff View commit details
    Browse the repository at this point in the history