UNI-1316 Borrower/Staker addresses functions #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UNI-1316 data columns missing from optimism and opgoe members table
Columns Missing:
|
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 82.64% 82.90% +0.25%
==========================================
Files 20 20
Lines 922 936 +14
Branches 173 173
==========================================
+ Hits 762 776 +14
Misses 98 98
Partials 62 62
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+77
to
+89
| function getBorrowerAddresses(address underlying, address account) public view returns (address[] memory) { | ||
| IUserManager userManager = IUserManager(marketRegistry.userManagers(underlying)); | ||
|
|
||
| uint256 voucheeCount = userManager.getVoucheeCount(account); | ||
| address[] memory addresses = new address[](voucheeCount); | ||
|
|
||
| for (uint256 i = 0; i < voucheeCount; i++) { | ||
| (address borrower, ) = userManager.vouchees(account, i); | ||
| addresses[i] = borrower; | ||
| } | ||
|
|
||
| return addresses; | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
Comment on lines
+91
to
+103
| function getStakerAddresses(address underlying, address account) public view returns (address[] memory) { | ||
| IUserManager userManager = IUserManager(marketRegistry.userManagers(underlying)); | ||
|
|
||
| uint256 voucherCount = userManager.getVoucherCount(account); | ||
| address[] memory addresses = new address[](voucherCount); | ||
|
|
||
| for (uint256 i = 0; i < voucherCount; i++) { | ||
| (address staker, , ,) = userManager.vouchers(account, i); | ||
| addresses[i] = staker; | ||
| } | ||
|
|
||
| return addresses; | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
There was a problem hiding this comment.
@0xbarbs How about add some unit tests for the new functions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
getBorrowerAddressesandgetStakerAddressesfunctions to the union lens contractt