Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy to Base and support USDC #172

Open
wants to merge 53 commits into
base: develop
Choose a base branch
from
Open

Deploy to Base and support USDC #172

wants to merge 53 commits into from

Conversation

maxweng
Copy link
Member

@maxweng maxweng commented Mar 15, 2024

No description provided.

@linear Linear
Copy link

linear bot commented Mar 15, 2024

UNI-1825 Deploy to Base Sepolia testnet

@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.36620% with 12 lines in your changes missing coverage. Please review.

Project coverage is 92.35%. Comparing base (436ede1) to head (0626512).
Report is 46 commits behind head on develop.

Files with missing lines Patch % Lines
contracts/UnionLens.sol 0.00% 10 Missing ⚠️
contracts/market/UToken.sol 98.78% 1 Missing ⚠️
contracts/user/UserManager.sol 98.97% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop     #172       +/-   ##
============================================
+ Coverage    81.89%   92.35%   +10.46%     
============================================
  Files           20       21        +1     
  Lines          928     1034      +106     
  Branches       176      179        +3     
============================================
+ Hits           760      955      +195     
+ Misses         106       79       -27     
+ Partials        62        0       -62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Mar 15, 2024 •
edited
Loading

Deploy to Base and support USDC

Generated at commit: 06265129a0aa43449aef3182bd60acb4a325f65a

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 1
1
0
7
32
41
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@maxweng maxweng changed the base branch from master to develop March 15, 2024 03:29
@kingjacob kingjacob requested a review from 0xbarbs March 29, 2024 09:54
@kingjacob kingjacob assigned kingjacob and maxweng and unassigned kingjacob Mar 29, 2024
kingjacob
kingjacob reviewed Jun 3, 2024
View reviewed changes
contracts/interfaces/IUserManager.sol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment

@maxweng maxweng force-pushed the feature/uni-1825-deploy-to-base-sepolia-testnet branch from ea625f8 to 353db2e Compare July 1, 2024 12:14
@maxweng maxweng force-pushed the feature/uni-1825-deploy-to-base-sepolia-testnet branch from 2f0fc7b to 0ce7036 Compare July 1, 2024 12:33
maxweng and others added 25 commits July 24, 2024 14:24
@maxweng
chg: add extra check on the withdrawal amount from the assetManager
1e6c540
@maxweng
chg: update to use the correct OZ lib
84eb9d7
@maxweng
fix: calculate the global total stake after total frozen is updated
9f1c1ea
@maxweng
fix: coverage report error
7c39016
@maxweng
fix: rounding up the utoken amount when redeeming
bb7454f
@maxweng
Merge remote-tracking branch 'origin/feature/uni-1825-deploy-to-base-…
b1786d2 
…sepolia-testnet' into finding/uni-1992-repaying-a-loan-with-permit-in-uerc20sol-wrongly-calculates

# Conflicts:
#	contracts/market/UToken.sol
#	slither.db.json
@maxweng
Merge pull request #175 from unioncredit/finding/uni-1992-repaying-a-…
10e974b 
…loan-with-permit-in-uerc20sol-wrongly-calculates

Minimum borrow amount can be surpassed
@twygod @maxweng
chg: consider introducing an option for rounding the decimalReducing(…
da5c99d 
…) output up
@twygod @maxweng
chg: add test
be12536
@twygod @maxweng
chg: modify coverage configuration
3ad06dc 
(cherry picked from commit 7c119a0)
(cherry picked from commit 42da009)
(cherry picked from commit 75bc675)
@twygod @maxweng
chg: add scaledDecimal test
2cc2c60
@twygod @maxweng
chg: update scaledDecimal test
2027dec
@twygod @maxweng
chg: update scaledDecimal test
d5d4996
@twygod @maxweng
fix: repayBorrowWithERC20Permit functions use incorrectly scaled accu…
9425e85 
…mulated interest value
@twygod @maxweng
chg: update test
037dbea
@twygod @maxweng
fix: exchangeRateStored decimals are incorrect and misaligned with ex…
1dd601d 
…changeRateCurrent
@twygod @maxweng
chg: update test
b47c6b8
@twygod @maxweng
fix: the amount of _totalStaked added when writeOffDebt is not scaled
295042b
@twygod @maxweng
chg: add test
3d6da9a
@maxweng
chg: max_borrow_rate to 100% apr
93934fa
@maxweng
Merge branch 'feature/uni-1825-deploy-to-base-sepolia-testnet' into f…
d3197fc 
…inding/uni-1989-wrong-calculation-of-accure-reward-in-comptrollersol

# Conflicts:
#	slither.db.json
@maxweng
Merge pull request #180 from unioncredit/finding/uni-1989-wrong-calcu…
ef7e42d 
…lation-of-accure-reward-in-comptrollersol

Wrong calculation of Accure Reward in Comptroller
@maxweng
fix: slither warnings
2216798
@twygod
new: deploye contract when fixed
65007a0
@twygod
chg: update contract address
0626512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingjacob kingjacob kingjacob left review comments

@0xbarbs 0xbarbs Awaiting requested review from 0xbarbs

Assignees

@maxweng maxweng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxweng @kingjacob @twygod