Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding up the utoken amount when redeeming #174

Conversation

maxweng
Copy link
Member

@maxweng maxweng commented Jul 23, 2024

No description provided.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (0ce7036) to head (caa08cd).
Report is 1 commits behind head on feature/uni-1825-deploy-to-base-sepolia-testnet.

Additional details and impacted files
@@                                 Coverage Diff                                 @@
##           feature/uni-1825-deploy-to-base-sepolia-testnet     #174      +/-   ##
===================================================================================
+ Coverage                                            84.29%   90.54%   +6.24%     
===================================================================================
  Files                                                   21       21              
  Lines                                                 1019     1026       +7     
  Branches                                               193      193              
===================================================================================
+ Hits                                                   859      929      +70     
- Misses                                                  89       94       +5     
+ Partials                                                71        3      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openzeppelin-code bot commented Jul 23, 2024

Rounding up the utoken amount when redeeming

Generated at commit: caa08cdbc78fe4d3fa1e3f1a56db5751e28ef7cf

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
7
33
42
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@maxweng maxweng force-pushed the finding/uni-1994-utoken-amount-to-be-burned-on-redeem-can-be-less-than-the branch from 5cbc0f0 to caa08cd Compare July 23, 2024 07:19
@maxweng maxweng requested review from twygod and kingjacob July 24, 2024 06:57
@maxweng maxweng merged commit bb7454f into feature/uni-1825-deploy-to-base-sepolia-testnet Aug 30, 2024
4 checks passed
@maxweng maxweng deleted the finding/uni-1994-utoken-amount-to-be-burned-on-redeem-can-be-less-than-the branch August 30, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant