Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding/uni 1993 exchangeratestored decimals are incorrect and misaligned #178

Conversation

twygod
Copy link
Contributor

@twygod twygod commented Jul 26, 2024

No description provided.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (0ce7036) to head (42da009).
Report is 15 commits behind head on feature/uni-1825-deploy-to-base-sepolia-testnet.

Additional details and impacted files
@@                                 Coverage Diff                                 @@
##           feature/uni-1825-deploy-to-base-sepolia-testnet     #178      +/-   ##
===================================================================================
- Coverage                                            84.29%   83.91%   -0.39%     
===================================================================================
  Files                                                   21       21              
  Lines                                                 1019     1026       +7     
  Branches                                               193      193              
===================================================================================
+ Hits                                                   859      861       +2     
- Misses                                                  89       94       +5     
  Partials                                                71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openzeppelin-code bot commented Jul 26, 2024

Finding/uni 1993 exchangeratestored decimals are incorrect and misaligned

Generated at commit: 42da00916c233c424c83d36b1b31825c2d6affe3

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
7
33
42
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

(cherry picked from commit 7c119a0)
@maxweng maxweng merged commit b47c6b8 into feature/uni-1825-deploy-to-base-sepolia-testnet Aug 30, 2024
4 checks passed
@maxweng maxweng deleted the finding/uni-1993-exchangeratestored-decimals-are-incorrect-and-misaligned branch August 30, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants