-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Merge Recorder and OutputManager. (#182)
* feat: Merge Recorder and OutputManager. This PR seeks to merge Recorder and OutputManager into a unified interface for processing commands and producing output, either to file or console. This ensures that: - Filtering (`|`or `|!`) works from commands called via `source` - Output to files is filtered as expected. - Removes recorder.py and its class. - Incorporates recording into OutputManager. - The OutputManager handles recording (mostly) behind the scenes if we're in recording mode. Outside of log handling we don't have to call recording tools explicitly as its done as part of normal output processing. - Incorporates table formatting into OutputManager where it belongs. - Moves command processing to a shared separate function called from both `source` and the interactive loop. - Adds commands to start and stop recording interactively. - Updates the prompt to show active recording if applicable. NOTE: This PR does not pass the current tests as it fixes #181. These changes should be thourughly reviewed and verified before new test logs are created. Fixes #179, fixes #181. * Add back a comment about shell commands called from scripts. * Clarify comments about recording related attributes. * Avoid reimplementing stop_recording when saving. * Update testsuite results.
- Loading branch information
Showing
11 changed files
with
528 additions
and
270 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.