Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building inside redhat/ubi8 container #307

Merged
merged 15 commits into from
Oct 11, 2024

Conversation

pederhan
Copy link
Member

This PR makes the following changes to the build and publish workflow:

  • Installs git before trying to check out the repo
  • Installs binutils to get the dependency objdump
    • objdump was installed by default in the CentOS 8 image, but not in redhat/ubi8 🙃
  • Fixes the tag pattern to work with tags like 1.0.0a1, 1.0.0rc1, etc.

Keeping the commit history so the pain I went through to change 18 lines is recorded for the world.

@pederhan pederhan requested a review from terjekv October 11, 2024 14:43
Copy link
Collaborator

@terjekv terjekv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terjekv terjekv merged commit 6dc4f6a into unioslo:master Oct 11, 2024
6 checks passed
@pederhan pederhan deleted the fix-building branch October 12, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants