Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified example in README.md #70

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

naman1303
Copy link

  1. Changed the year from 2016 to 2020 (for exact 'planned' Olympics year)
  2. Other minor changes

@naman1303
Copy link
Author

I am doing this PR activity after a long time, so got confused while trying to compare the fork with master branch, thus you will see multiple commits - please ignore those.
I have executed the example go code before pushing my branch.

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #70 (06e7b92) into master (ce063dd) will increase coverage by 0.94%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   89.11%   90.06%   +0.94%     
==========================================
  Files           3        3              
  Lines         634      634              
==========================================
+ Hits          565      571       +6     
+ Misses         44       39       -5     
+ Partials       25       24       -1     
Impacted Files Coverage Δ
carbon.go 91.13% <100.00%> (+0.66%) ⬆️
translator.go 65.51% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c77b65...06e7b92. Read the comment docs.

@rntdrts
Copy link
Contributor

rntdrts commented Oct 29, 2021

I am doing this PR activity after a long time, so got confused while trying to compare the fork with master branch, thus you will see multiple commits - please ignore those. I have executed the example go code before pushing my branch.

hey @naman1303!

Thank you for your contribution! Please let me know when this is ready for review! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants