[RFC][NI] Add readOnly property to checked property on radio-button #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmelo
approved these changes
May 2, 2018
|
All computed properties should be readonly by default, but this really enforces it. Btw, tests are failing :) Good job :) |
|
@asantos00 As you can see by the failing tests, sometimes it's better to be safe than sorry :D |
asantos00
approved these changes
May 2, 2018
AndreJoaquim
force-pushed
the
NI/add-ro-to-rb
branch
2 times, most recently
from
6fb97f7
to
5bb2b7e
Compare
rntdrts
approved these changes
Sep 7, 2018
henrmota
approved these changes
Sep 7, 2018
asantos00
approved these changes
Sep 11, 2018
AndreJoaquim
force-pushed
the
NI/add-ro-to-rb
branch
from
5bb2b7e
to
3e457d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The checked property of the radio-button shouldn't be changeable. This property is fully managed by the component. Any parent component is only allowed to change the
groupValueproperty, triggering thecheckedcomputed.Further improvements:
See issue #246