Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and test methods to alter an existing deposit #18

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

apbendi
Copy link
Collaborator

@apbendi apbendi commented Jan 14, 2024

This PR implements and tests methods that allow depositors to alter their existing deposits in some way. In particular, this includes methods that allow a depositor to:

  • Add more stake to an existing deposit
  • Update the delegatee of an existing deposit
  • Update the beneficiary of an existing deposit

Additionally the PR implements a restriction on using the zero address as the delegatee or beneficiary. This is a business requirement from the stakeholders.

@apbendi apbendi changed the title Implement and test methods to alter deposit's delegatgee & beneficiary Implement and test methods to alter an existing deposit Jan 15, 2024
@apbendi apbendi marked this pull request as ready for review January 15, 2024 03:10
@apbendi apbendi changed the base branch from stake-earn to main January 19, 2024 22:20
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to be rebased to remove the existing changes in main

src/UniStaker.sol Show resolved Hide resolved
src/UniStaker.sol Show resolved Hide resolved
Copy link

Coverage after merging alter-stake into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   UniStaker.sol98.21%95%93.75%100%175
   V3FactoryOwner.sol100%100%100%100%

Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/UniStaker.sol Show resolved Hide resolved
test/UniStaker.t.sol Show resolved Hide resolved
@apbendi apbendi merged commit 186e279 into main Jan 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants