Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements two small naming fixes #21

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Implements two small naming fixes #21

merged 2 commits into from
Jan 24, 2024

Conversation

apbendi
Copy link
Collaborator

@apbendi apbendi commented Jan 23, 2024

@github-actions GitHub Actions
Copy link

Coverage after merging small-fixes into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   UniStaker.sol97.40%94.44%90.91%100%132
   V3FactoryOwner.sol100%100%100%100%

alexkeating
alexkeating approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment unrelated to the pr

src/UniStaker.sol Show resolved Hide resolved
wildmolasses
wildmolasses approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apbendi apbendi merged commit af7b4dd into main Jan 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildmolasses wildmolasses wildmolasses approved these changes

@alexkeating alexkeating alexkeating approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apbendi @wildmolasses @alexkeating