Add events and update expectEmits #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeating
force-pushed
the
chore/add-events
branch
from
d502786
to
7be0380
Compare
alexkeating
commented
Jan 26, 2024
alexkeating
commented
Jan 29, 2024
alexkeating
requested review from
apbendi and
wildmolasses
and removed request for
apbendi
alexkeating
changed the title
wildmolasses
changed the title
apbendi
requested changes
Jan 29, 2024
alexkeating
force-pushed
the
chore/add-events
branch
2 times, most recently
from
708c360
to
9e5c475
Compare
apbendi
reviewed
Jan 31, 2024
There was a problem hiding this comment.
A few more small things @alexkeating, getting close on this.
apbendi
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Sorry for the churn here @alexkeating but there's still a couple things that jumped out at me.
alexkeating
force-pushed
the
chore/add-events
branch
from
2ed3149
to
81c09f4
Compare
apbendi
force-pushed
the
chore/add-events
branch
from
81c09f4
to
4ffe532
Compare
apbendi
approved these changes
Feb 1, 2024
|
Coverage after merging chore/add-events into main will be
Coverage Report
|
|||||||||||||||||||||||||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22 #16