Add owner to StakeDeposited #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging chore/add-owner-to-stake-deposited into main will be
Coverage Report
|
|||||||||||||||||||||||||
wildmolasses
approved these changes
Feb 7, 2024
| @@ -426,7 +428,7 @@ contract UniStaker is INotifiableRewardReceiver, ReentrancyGuard, Multicall { | |||
| delegatee: _delegatee, | |||
| beneficiary: _beneficiary | |||
| }); | |||
| emit StakeDeposited(_depositId, _amount, _amount); | |||
| emit StakeDeposited(msg.sender, _depositId, _amount, _amount); | |||
There was a problem hiding this comment.
a note here that this will turn into deposit.owner when #43 is merged. whichever is merged first, we should take care to update in the correct place.
Suggested change
| emit StakeDeposited(msg.sender, _depositId, _amount, _amount); | |
| emit StakeDeposited(deposit.owner, _depositId, _amount, _amount); |
There was a problem hiding this comment.
Good call out @wildmolasses, looks like this one will make it in first so please be sure to rebase, thanks!
apbendi
approved these changes
Feb 7, 2024
| @@ -426,7 +428,7 @@ contract UniStaker is INotifiableRewardReceiver, ReentrancyGuard, Multicall { | |||
| delegatee: _delegatee, | |||
| beneficiary: _beneficiary | |||
| }); | |||
| emit StakeDeposited(_depositId, _amount, _amount); | |||
| emit StakeDeposited(msg.sender, _depositId, _amount, _amount); | |||
There was a problem hiding this comment.
Good call out @wildmolasses, looks like this one will make it in first so please be sure to rebase, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StakeDeposited