Deposit accounting #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apbendi
force-pushed
the
deposit-accounting
branch
2 times, most recently
from
ca84d74
to
9c110e1
Compare
apbendi
force-pushed
the
deposit-accounting
branch
from
9c110e1
to
4404500
Compare
alexkeating
reviewed
Dec 21, 2023
apbendi
force-pushed
the
deposit-accounting
branch
from
4404500
to
1fd0d07
Compare
alexkeating
approved these changes
Dec 22, 2023
apbendi
force-pushed
the
deposit-accounting
branch
from
1fd0d07
to
a330505
Compare
|
Coverage after merging deposit-accounting into main will be
Coverage Report
|
|||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic accounting to track per-deposit, per-depositor, and global accounting information when users stake tokens. It does not add the ability to withdraw or modify deposits, nor does it implement any of the logic around actually earning rewards from stake. Those features will be implemented in future PRs.