In UniStaker tests, remember depositors and surrogates and prevent overlap #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erlap Due to a recent, undocumented change in the Foundry fuzzer implementation, we are now seeing test failures where the address of a yet-to-be-deployed DelegationSurrogate is selected as a depositor. This breaks our tests. This is occuring despite the include_storage flag being set to false, which previously was sufficient for preventing this edge case. To accomodate this, we implement a test helper that remembers each depositor and surrogate as they're chosen and deployed respectively, and assures there is no overlap between the two groups of addresses.
|
Coverage after merging fix-surrogate-depositor-fuzz into main will be
Coverage Report
|
|||||||||||||||||||||||||
alexkeating
approved these changes
Mar 22, 2024
wildmolasses
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a recent, undocumented change in the Foundry fuzzer implementation, we are now seeing test failures where the address of a yet-to-be-deployed DelegationSurrogate is selected as a depositor. This breaks our tests. This is occuring despite the include_storage flag being set to false, which previously was sufficient for preventing this edge case.
To accomodate this, we implement a test helper that remembers each depositor and surrogate as they're chosen and deployed respectively, and assures there is no overlap between the two groups of addresses.