Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add try/catch to permitAndStake, permitAndStakeMore #85

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

wildmolasses
Copy link
Collaborator

resolves #80

@wildmolasses wildmolasses requested review from alexkeating and apbendi and removed request for alexkeating April 9, 2024 16:10
src/UniStaker.sol Show resolved Hide resolved
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it also looks like there is a failing test

@wildmolasses
Copy link
Collaborator Author

Fixed the tests, let me know if you think they satisfy

Copy link

Coverage after merging 04-09-permit_trycatch into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   UniStaker.sol99.52%96.15%100%100%670
   V3FactoryOwner.sol100%100%100%100%

Copy link
Collaborator

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@apbendi apbendi merged commit 4ce183a into main Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add try/catch to permitAndStake, permitAndStakeMore
3 participants