Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript: improved parsing of anonymous functions #3437

Merged

Conversation

jafl
Copy link
Contributor

@jafl jafl commented Jul 12, 2022

This is much simpler than #2005

@jafl jafl requested a review from masatake July 12, 2022 01:46
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #3437 (e9cff6d) into master (56813d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3437   +/-   ##
=======================================
  Coverage   83.35%   83.35%           
=======================================
  Files         218      218           
  Lines       52510    52512    +2     
=======================================
+ Hits        43769    43772    +3     
+ Misses       8741     8740    -1     
Impacted Files Coverage Δ
parsers/jscript.c 97.46% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56813d1...e9cff6d. Read the comment docs.

@jafl
Copy link
Contributor Author

jafl commented Jul 12, 2022

@masatake If I do a major refactor of parseStatement to break it up, will that cause major pain for any of your other jscript.c PR's?

@masatake
Copy link
Member

Incredible!

@masatake
Copy link
Member

Let's ignore the testing on NetBSD.

@masatake
Copy link
Member

@masatake If I do a major refactor of parseStatement to break it up, will that cause major pain for any of your other jscript.c PR's?

I submitted #3433 and #3435. However, I don't care if your future pull request breaks them. Refactoring has a much higher priority!

@masatake
Copy link
Member

BTW if you want to let users of the JavaScript parser know the design of the parser, you can write a man page for it. See https://docs.ctags.io/en/latest/man-pages.html and https://docs.ctags.io/en/latest/man/ctags-lang-python.7.html as examples.

@jafl jafl merged commit 7b5c7ef into universal-ctags:master Jul 12, 2022
@jafl jafl deleted the javascript-improve-anonymous-functions branch July 12, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants