-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Number entity type, and update README docs for Switch and Button #115
Conversation
e62d8df
to
b31a89f
Compare
Heya, I'm noticing that the linter is unhappy about |
README.md
Outdated
# Information about the `number` entity. | ||
number_info = NumberInfo(name="test", min=0, max=50, mode="slider", step=5) | ||
|
||
settings = Settings(mqtt=mqtt_settings, entity=switch_info) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vestigial switch_info
settings = Settings(mqtt=mqtt_settings, entity=number_info)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philharlow Updated, along with some similar pre-existing mis-names.
@unixorn Bump. Anything you'd like me to do on this PR? I can reformat that file to pass the linter, though I'm not sure about how it was passing the linter in the first place. |
@DavidMikeSimon, if you're willing, I'd appreciate the formatting help. Sorry I've been slow, work's been busy busy. |
7feaf0d
to
c1f01c9
Compare
Signed-off-by: David Simon <[email protected]>
Signed-off-by: David Simon <[email protected]>
Signed-off-by: David Simon <[email protected]>
c1f01c9
to
58dcbf6
Compare
@unixorn Ok, lints passing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help!
- Add `state_class` property to Sensor class, fixes #96 - Add ability to specify non-standard MQTT ports, closes #91 - Various dependency bumps - Add `Number` entity type, and update README docs for `Switch` and `Button` in #115 Signed-off-by: Joe Block <[email protected]>
- Add `state_class` property to Sensor class, fixes #96 - Add ability to specify non-standard MQTT ports, closes #91 - Add `Number` entity type, and update README docs for `Switch` and `Button` in #115 - Put entity types in alphabetical order in README.md - Update TOC in README.md - Various dependency bumps Signed-off-by: Joe Block <[email protected]>
Number
entity, which can control a single numeric value (just like howText
can control a single string)Number
to theREADME
Number
(similar to theText
tests)README
:Button
, which was undocumented before.write_config()
to make buttons discoverableSwitch
"ON"
payload for aSwitch
, it's your job to callon()
)License Acceptance
Type of changes
Checklist
#!/usr/bin/env interpreter
instead of potentially platform-specific direct paths (#!/bin/sh
is an allowed exception)