Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: add crossplane crank sub-commands to up #341

Closed
wants to merge 2 commits into from

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jul 6, 2023

$ up xp install provider crossplane/provider-gcp:main
$ ...

Requires crossplane/crossplane#4298.

@sttts sttts force-pushed the sttts-import-crank-commands branch from 3ca1068 to bccd364 Compare July 6, 2023 12:01
@sttts sttts requested a review from AlainRoy July 6, 2023 12:02
@negz
Copy link
Member

negz commented Jul 7, 2023

@sttts I think up already has all (maybe almost all?) of the functionality this would add. I also believe the functionality in up is newer/"better" than what would be added by embedding Crossplane. See for example:

I agree broadly that it would make more sense for this functionality to live in crank and for up to sub package it. If that's where you're going with crossplane/crossplane#4298 can you please raise an issue on c/c proposing this before we proceed?

@sttts
Copy link
Contributor Author

sttts commented Jul 8, 2023

This is just a PoC to show integration of both is easy. We talked about that earlier that we might want to revive crank to get more purely-in-control-plane features (think of diagnose, composition + functions tooling etc.)

Actually, I would actually suggest to move xpkg over to crank and reimport here.

But yeah, this needs some kind of design doc, at least a one-pager. It's not super complex, so maybe a one-pager is enough to clarify the direction.

@jastang
Copy link
Contributor

jastang commented Oct 5, 2023

should we close this in favour of vendoring in the upstream changes, e.g. crossplane/crossplane#4694 and crossplane/crossplane#4271?

@sttts
Copy link
Contributor Author

sttts commented Oct 5, 2023

should we close this in favour of vendoring in the upstream changes, e.g. crossplane/crossplane#4694 and crossplane/crossplane#4271?

This is the up side. It's a different topic than promoting crank to crossplane in upstream. Here we want to integrate the upstream command into up.

@jastang
Copy link
Contributor

jastang commented Oct 5, 2023

should we close this in favour of vendoring in the upstream changes, e.g. crossplane/crossplane#4694 and crossplane/crossplane#4271?

This is the up side. It's a different topic than promoting crank to crossplane in upstream. Here we want to integrate the upstream command into up.

Right, I was referring to vendoring the packaging functionality back into up once it's fully introduced as crossplane xpkg upstream like you mention above. I might just be missing a subtle difference.

@haarchri
Copy link
Member

not planned

@haarchri haarchri closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants