Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump etcd image version to 3.5.15-0 #625

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

erhancagirici
Copy link
Contributor

@erhancagirici erhancagirici commented Oct 2, 2024

Description of your changes

https://github.com/upbound/spaces/pull/1708 bumps etcd image version used in spaces 1.8
This PR adds the mirrored etcd image version to 3.5.15-0 for spaces >=1.8.x
and keeps the 3.5.6-0 with the compatible version<=1.7.x

Complements #620

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Build up cli

make build

for spaces 1.8.x

_output/bin/darwin_arm64/up space mirror --dry-run \
                  --version=1.8.0-rc.1 \
                  --to-dir=~/spaces-images-test | grep etcd

# output:
# crane pull xpkg.upbound.io/spaces-artifacts/etcd:3.5.15-0 ~/spaces-images-test/etcd-3.5.15-0.tgz

for spaces <=1.7.x

_output/bin/darwin_arm64/up space mirror --dry-run \
                  --version=1.7.2 \
                  --to-dir=./spaces-images | grep kubectl

# output:
# crane pull xpkg.upbound.io/spaces-artifacts/etcd:3.5.15-0 ~/spaces-images-test/etcd-3.5.6-0.tgz

@erhancagirici erhancagirici self-assigned this Oct 2, 2024
@erhancagirici erhancagirici merged commit 7f73863 into upbound:main Oct 2, 2024
7 checks passed
@erhancagirici erhancagirici deleted the bump-mirror-etcd-3150 branch October 2, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants